diff options
| author | nixiaoming <nixiaoming@huawei.com> | 2017-08-31 12:51:09 +0200 |
|---|---|---|
| committer | Paul Mackerras <paulus@ozlabs.org> | 2017-09-01 02:17:58 +0200 |
| commit | 43f6b0cfb2e4dfd5aa452a1d44491e805e37b7da (patch) | |
| tree | cea9bf0ef257d98d80b3a24c755f30b2080ddb9f /arch/powerpc | |
| parent | Merge remote-tracking branch 'remotes/powerpc/topic/ppc-kvm' into kvm-ppc-next (diff) | |
| download | linux-43f6b0cfb2e4dfd5aa452a1d44491e805e37b7da.tar.xz linux-43f6b0cfb2e4dfd5aa452a1d44491e805e37b7da.zip | |
KVM: PPC: Book3S HV: Fix memory leak in kvm_vm_ioctl_get_htab_fd
We do ctx = kzalloc(sizeof(*ctx), GFP_KERNEL) and then later on call
anon_inode_getfd(), but if that fails we don't free ctx, so that
memory gets leaked. To fix it, this adds kfree(ctx) in the failure
path.
Signed-off-by: nixiaoming <nixiaoming@huawei.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
Diffstat (limited to 'arch/powerpc')
| -rw-r--r-- | arch/powerpc/kvm/book3s_64_mmu_hv.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c index 67075e065ef2..7c62967d672c 100644 --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c @@ -1941,6 +1941,7 @@ int kvm_vm_ioctl_get_htab_fd(struct kvm *kvm, struct kvm_get_htab_fd *ghf) rwflag = (ghf->flags & KVM_GET_HTAB_WRITE) ? O_WRONLY : O_RDONLY; ret = anon_inode_getfd("kvm-htab", &kvm_htab_fops, ctx, rwflag | O_CLOEXEC); if (ret < 0) { + kfree(ctx); kvm_put_kvm(kvm); return ret; } |