summaryrefslogtreecommitdiffstats
path: root/arch/s390/include
diff options
context:
space:
mode:
authorCornelia Huck <cohuck@redhat.com>2021-02-16 12:06:45 +0100
committerVasily Gorbik <gor@linux.ibm.com>2021-02-24 00:31:23 +0100
commit182f709c5cff683e6732d04c78e328de0532284f (patch)
tree1fbc0bf02e0b17e8e4eae2c89102dbdbaed29f6a /arch/s390/include
parents390/smp: implement arch_irq_work_raise() (diff)
downloadlinux-182f709c5cff683e6732d04c78e328de0532284f.tar.xz
linux-182f709c5cff683e6732d04c78e328de0532284f.zip
virtio/s390: implement virtio-ccw revision 2 correctly
CCW_CMD_READ_STATUS was introduced with revision 2 of virtio-ccw, and drivers should only rely on it being implemented when they negotiated at least that revision with the device. However, virtio_ccw_get_status() issued READ_STATUS for any device operating at least at revision 1. If the device accepts READ_STATUS regardless of the negotiated revision (which some implementations like QEMU do, even though the spec currently does not allow it), everything works as intended. While a device rejecting the command should also be handled gracefully, we will not be able to see any changes the device makes to the status, such as setting NEEDS_RESET or setting the status to zero after a completed reset. We negotiated the revision to at most 1, as we never bumped the maximum revision; let's do that now and properly send READ_STATUS only if we are operating at least at revision 2. Cc: stable@vger.kernel.org Fixes: 7d3ce5ab9430 ("virtio/s390: support READ_STATUS command for virtio-ccw") Reviewed-by: Halil Pasic <pasic@linux.ibm.com> Signed-off-by: Cornelia Huck <cohuck@redhat.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com> Link: https://lore.kernel.org/r/20210216110645.1087321-1-cohuck@redhat.com Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Diffstat (limited to 'arch/s390/include')
0 files changed, 0 insertions, 0 deletions