summaryrefslogtreecommitdiffstats
path: root/arch/um/drivers/line.c
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2024-07-03 17:22:36 +0200
committerJohannes Berg <johannes.berg@intel.com>2024-07-04 12:03:14 +0200
commit824ac4a5edd3f7494ab1996826c4f47f8ef0f63d (patch)
tree67539430bc4fefd8b76ca75821e369cc3bea851f /arch/um/drivers/line.c
parentum: remove pcap driver from documentation (diff)
downloadlinux-824ac4a5edd3f7494ab1996826c4f47f8ef0f63d.tar.xz
linux-824ac4a5edd3f7494ab1996826c4f47f8ef0f63d.zip
um: line: always fill *error_out in setup_one_line()
The pointer isn't initialized by callers, but I have encountered cases where it's still printed; initialize it in all possible cases in setup_one_line(). Link: https://patch.msgid.link/20240703172235.ad863568b55f.Iaa1eba4db8265d7715ba71d5f6bb8c7ff63d27e9@changeid Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'arch/um/drivers/line.c')
-rw-r--r--arch/um/drivers/line.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
index d82bc3fdb86e..43d8959cc746 100644
--- a/arch/um/drivers/line.c
+++ b/arch/um/drivers/line.c
@@ -383,6 +383,7 @@ int setup_one_line(struct line *lines, int n, char *init,
parse_chan_pair(NULL, line, n, opts, error_out);
err = 0;
}
+ *error_out = "configured as 'none'";
} else {
char *new = kstrdup(init, GFP_KERNEL);
if (!new) {
@@ -406,6 +407,7 @@ int setup_one_line(struct line *lines, int n, char *init,
}
}
if (err) {
+ *error_out = "failed to parse channel pair";
line->init_str = NULL;
line->valid = 0;
kfree(new);