summaryrefslogtreecommitdiffstats
path: root/arch/um/drivers/slip_user.c
diff options
context:
space:
mode:
authorZhen Lei <thunder.leizhen@huawei.com>2021-05-08 05:13:54 +0200
committerRichard Weinberger <richard@nod.at>2021-06-17 22:10:05 +0200
commitb77e81fbe5f5fb4ad9a61ec80f6d1e30b6da093a (patch)
tree1ce5ed138f8e33391402ee03eb58efd38024538a /arch/um/drivers/slip_user.c
parentum: Fix stack pointer alignment (diff)
downloadlinux-b77e81fbe5f5fb4ad9a61ec80f6d1e30b6da093a.tar.xz
linux-b77e81fbe5f5fb4ad9a61ec80f6d1e30b6da093a.zip
um: fix error return code in slip_open()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: a3c77c67a443 ("[PATCH] uml: slirp and slip driver cleanups and fixes") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Acked-By: anton.ivanov@cambridgegreys.com Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'arch/um/drivers/slip_user.c')
-rw-r--r--arch/um/drivers/slip_user.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/um/drivers/slip_user.c b/arch/um/drivers/slip_user.c
index 482a19c5105c..7334019c9e60 100644
--- a/arch/um/drivers/slip_user.c
+++ b/arch/um/drivers/slip_user.c
@@ -145,7 +145,8 @@ static int slip_open(void *data)
}
sfd = err;
- if (set_up_tty(sfd))
+ err = set_up_tty(sfd);
+ if (err)
goto out_close2;
pri->slave = sfd;