diff options
author | Zhipeng Xie <xiezhipeng1@huawei.com> | 2022-02-09 15:54:17 +0100 |
---|---|---|
committer | Peter Zijlstra <peterz@infradead.org> | 2022-04-19 21:15:42 +0200 |
commit | 60490e7966659b26d74bf1fa4aa8693d9a94ca88 (patch) | |
tree | a14ccb4487d1e3938f0cc525803dd989999f12fb /arch/x86/events/intel/cstate.c | |
parent | Linux 5.18-rc3 (diff) | |
download | linux-60490e7966659b26d74bf1fa4aa8693d9a94ca88.tar.xz linux-60490e7966659b26d74bf1fa4aa8693d9a94ca88.zip |
perf/core: Fix perf_mmap fail when CONFIG_PERF_USE_VMALLOC enabled
This problem can be reproduced with CONFIG_PERF_USE_VMALLOC enabled on
both x86_64 and aarch64 arch when using sysdig -B(using ebpf)[1].
sysdig -B works fine after rebuilding the kernel with
CONFIG_PERF_USE_VMALLOC disabled.
I tracked it down to the if condition event->rb->nr_pages != nr_pages
in perf_mmap is true when CONFIG_PERF_USE_VMALLOC is enabled where
event->rb->nr_pages = 1 and nr_pages = 2048 resulting perf_mmap to
return -EINVAL. This is because when CONFIG_PERF_USE_VMALLOC is
enabled, rb->nr_pages is always equal to 1.
Arch with CONFIG_PERF_USE_VMALLOC enabled by default:
arc/arm/csky/mips/sh/sparc/xtensa
Arch with CONFIG_PERF_USE_VMALLOC disabled by default:
x86_64/aarch64/...
Fix this problem by using data_page_nr()
[1] https://github.com/draios/sysdig
Fixes: 906010b2134e ("perf_event: Provide vmalloc() based mmap() backing")
Signed-off-by: Zhipeng Xie <xiezhipeng1@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20220209145417.6495-1-xiezhipeng1@huawei.com
Diffstat (limited to 'arch/x86/events/intel/cstate.c')
0 files changed, 0 insertions, 0 deletions