diff options
| author | Sean Christopherson <seanjc@google.com> | 2023-02-16 21:22:54 +0100 |
|---|---|---|
| committer | Sean Christopherson <seanjc@google.com> | 2023-03-24 00:07:52 +0100 |
| commit | 65966aaca18a5cbf42ac22234cb9cbbf60a4d33c (patch) | |
| tree | b4f226c6d7934cfc655e99bc89c15bfb20ed78fd /arch/x86/kvm/emulate.c | |
| parent | x86: KVM: Add common feature flag for AMD's PSFD (diff) | |
| download | linux-65966aaca18a5cbf42ac22234cb9cbbf60a4d33c.tar.xz linux-65966aaca18a5cbf42ac22234cb9cbbf60a4d33c.zip | |
KVM: x86: Assert that the emulator doesn't load CS with garbage in !RM
Yell loudly if KVM attempts to load CS outside of Real Mode without an
accompanying control transfer type, i.e. on X86_TRANSFER_NONE. KVM uses
X86_TRANSFER_NONE when emulating IRET and exceptions/interrupts for Real
Mode, but IRET emulation for Protected Mode is non-existent. WARN instead
of trying to pass in a less-wrong type, e.g. X86_TRANSFER_RET, as
emulating IRET goes even beyond emulating FAR RET (which KVM also doesn't
fully support).
Reported-by: Hou Wenlong <houwenlong.hwl@antgroup.com>
Link: https://lore.kernel.org/r/20230216202254.671772-1-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'arch/x86/kvm/emulate.c')
| -rw-r--r-- | arch/x86/kvm/emulate.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index a20bec931764..936a397a08cd 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -1640,6 +1640,14 @@ static int __load_segment_descriptor(struct x86_emulate_ctxt *ctxt, goto exception; break; case VCPU_SREG_CS: + /* + * KVM uses "none" when loading CS as part of emulating Real + * Mode exceptions and IRET (handled above). In all other + * cases, loading CS without a control transfer is a KVM bug. + */ + if (WARN_ON_ONCE(transfer == X86_TRANSFER_NONE)) + goto exception; + if (!(seg_desc.type & 8)) goto exception; |