diff options
| author | Ammar Faizi <ammarfaizi2@gnuweeb.org> | 2022-03-29 12:47:04 +0200 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2022-04-05 21:21:57 +0200 |
| commit | b86eb74098a92afd789da02699b4b0dd3f73b889 (patch) | |
| tree | 07d438c5a53593f0a4251fba4dff0b77df28fbd7 /arch/x86/lib | |
| parent | x86/amd_nb: Unexport amd_cache_northbridges() (diff) | |
| download | linux-b86eb74098a92afd789da02699b4b0dd3f73b889.tar.xz linux-b86eb74098a92afd789da02699b4b0dd3f73b889.zip | |
x86/delay: Fix the wrong asm constraint in delay_loop()
The asm constraint does not reflect the fact that the asm statement can
modify the value of the local variable loops. Which it does.
Specifying the wrong constraint may lead to undefined behavior, it may
clobber random stuff (e.g. local variable, important temporary value in
regs, etc.). This is especially dangerous when the compiler decides to
inline the function and since it doesn't know that the value gets
modified, it might decide to use it from a register directly without
reloading it.
Change the constraint to "+a" to denote that the first argument is an
input and an output argument.
[ bp: Fix typo, massage commit message. ]
Fixes: e01b70ef3eb3 ("x86: fix bug in arch/i386/lib/delay.c file, delay_loop function")
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20220329104705.65256-2-ammarfaizi2@gnuweeb.org
Diffstat (limited to 'arch/x86/lib')
| -rw-r--r-- | arch/x86/lib/delay.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/lib/delay.c b/arch/x86/lib/delay.c index 65d15df6212d..0e65d00e2339 100644 --- a/arch/x86/lib/delay.c +++ b/arch/x86/lib/delay.c @@ -54,8 +54,8 @@ static void delay_loop(u64 __loops) " jnz 2b \n" "3: dec %0 \n" - : /* we don't need output */ - :"a" (loops) + : "+a" (loops) + : ); } |