summaryrefslogtreecommitdiffstats
path: root/arch/x86/lib
diff options
context:
space:
mode:
authorH. Peter Anvin <hpa@zytor.com>2013-02-12 08:14:48 +0100
committerH. Peter Anvin <hpa@zytor.com>2013-02-12 08:14:48 +0100
commit16640165c9079e2cf36fdcfca093f29663a716f7 (patch)
treed59440ab4262c4d9fa2fbd9ed8677545555b27c7 /arch/x86/lib
parentx86, mm: Use a bitfield to mask nuisance get_user() warnings (diff)
downloadlinux-16640165c9079e2cf36fdcfca093f29663a716f7.tar.xz
linux-16640165c9079e2cf36fdcfca093f29663a716f7.zip
x86: Be consistent with data size in getuser.S
Consistently use the data register by name and use a sized assembly instruction in getuser.S. There is never any reason to macroize it, and being inconsistent in the same file is just annoying. No actual code change. Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86/lib')
-rw-r--r--arch/x86/lib/getuser.S10
1 files changed, 5 insertions, 5 deletions
diff --git a/arch/x86/lib/getuser.S b/arch/x86/lib/getuser.S
index d3bf9f99ca77..a4512359656a 100644
--- a/arch/x86/lib/getuser.S
+++ b/arch/x86/lib/getuser.S
@@ -41,7 +41,7 @@ ENTRY(__get_user_1)
cmp TI_addr_limit(%_ASM_DX),%_ASM_AX
jae bad_get_user
ASM_STAC
-1: movzb (%_ASM_AX),%edx
+1: movzbl (%_ASM_AX),%edx
xor %eax,%eax
ASM_CLAC
ret
@@ -71,7 +71,7 @@ ENTRY(__get_user_4)
cmp TI_addr_limit(%_ASM_DX),%_ASM_AX
jae bad_get_user
ASM_STAC
-3: mov -3(%_ASM_AX),%edx
+3: movl -3(%_ASM_AX),%edx
xor %eax,%eax
ASM_CLAC
ret
@@ -87,7 +87,7 @@ ENTRY(__get_user_8)
cmp TI_addr_limit(%_ASM_DX),%_ASM_AX
jae bad_get_user
ASM_STAC
-4: movq -7(%_ASM_AX),%_ASM_DX
+4: movq -7(%_ASM_AX),%rdx
xor %eax,%eax
ASM_CLAC
ret
@@ -98,8 +98,8 @@ ENTRY(__get_user_8)
cmp TI_addr_limit(%_ASM_DX),%_ASM_AX
jae bad_get_user_8
ASM_STAC
-4: mov -7(%_ASM_AX),%edx
-5: mov -3(%_ASM_AX),%ecx
+4: movl -7(%_ASM_AX),%edx
+5: movl -3(%_ASM_AX),%ecx
xor %eax,%eax
ASM_CLAC
ret