diff options
| author | Robert Richter <robert.richter@amd.com> | 2010-08-30 10:56:18 +0200 |
|---|---|---|
| committer | Robert Richter <robert.richter@amd.com> | 2010-08-31 10:26:26 +0200 |
| commit | 10f0412f57f2a76a90eff4376f59cbb0a39e4e18 (patch) | |
| tree | 6e038c3816b5e1f61a498ed69cd730d5e4e832ef /arch/x86/oprofile | |
| parent | oprofile: fix crash when accessing freed task structs (diff) | |
| download | linux-10f0412f57f2a76a90eff4376f59cbb0a39e4e18.tar.xz linux-10f0412f57f2a76a90eff4376f59cbb0a39e4e18.zip | |
oprofile, x86: fix init_sysfs error handling
On failure init_sysfs() might not properly free resources. The error
code of the function is not checked. And, when reinitializing the exit
function might be called twice. This patch fixes all this.
Cc: stable@kernel.org
Signed-off-by: Robert Richter <robert.richter@amd.com>
Diffstat (limited to 'arch/x86/oprofile')
| -rw-r--r-- | arch/x86/oprofile/nmi_int.c | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c index f6b48f6c5951..73a41d3c6c09 100644 --- a/arch/x86/oprofile/nmi_int.c +++ b/arch/x86/oprofile/nmi_int.c @@ -568,8 +568,13 @@ static int __init init_sysfs(void) int error; error = sysdev_class_register(&oprofile_sysclass); - if (!error) - error = sysdev_register(&device_oprofile); + if (error) + return error; + + error = sysdev_register(&device_oprofile); + if (error) + sysdev_class_unregister(&oprofile_sysclass); + return error; } @@ -695,6 +700,8 @@ int __init op_nmi_init(struct oprofile_operations *ops) char *cpu_type = NULL; int ret = 0; + using_nmi = 0; + if (!cpu_has_apic) return -ENODEV; @@ -774,7 +781,10 @@ int __init op_nmi_init(struct oprofile_operations *ops) mux_init(ops); - init_sysfs(); + ret = init_sysfs(); + if (ret) + return ret; + using_nmi = 1; printk(KERN_INFO "oprofile: using NMI interrupt.\n"); return 0; |