diff options
author | Hugh Dickins <hughd@google.com> | 2018-07-14 21:58:07 +0200 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2018-07-15 11:38:44 +0200 |
commit | 2c991e408df6a407476dbc453d725e1e975479e7 (patch) | |
tree | 6ae5f018abe25b8cfa3b66e6c83cb8b5e5355066 /arch/x86/video | |
parent | Merge tag 'rtc-4.18-2' of git://git.kernel.org/pub/scm/linux/kernel/git/abell... (diff) | |
download | linux-2c991e408df6a407476dbc453d725e1e975479e7.tar.xz linux-2c991e408df6a407476dbc453d725e1e975479e7.zip |
x86/events/intel/ds: Fix bts_interrupt_threshold alignment
Markus reported that BTS is sporadically missing the tail of the trace
in the perf_event data buffer: [decode error (1): instruction overflow]
shown in GDB; and bisected it to the conversion of debug_store to PTI.
A little "optimization" crept into alloc_bts_buffer(), which mistakenly
placed bts_interrupt_threshold away from the 24-byte record boundary.
Intel SDM Vol 3B 17.4.9 says "This address must point to an offset from
the BTS buffer base that is a multiple of the BTS record size."
Revert "max" from a byte count to a record count, to calculate the
bts_interrupt_threshold correctly: which turns out to fix problem seen.
Fixes: c1961a4631da ("x86/events/intel/ds: Map debug buffers in cpu_entry_area")
Reported-and-tested-by: Markus T Metzger <markus.t.metzger@intel.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@intel.com>
Cc: Andi Kleen <andi.kleen@intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: stable@vger.kernel.org # v4.14+
Link: https://lkml.kernel.org/r/alpine.LSU.2.11.1807141248290.1614@eggly.anvils
Diffstat (limited to 'arch/x86/video')
0 files changed, 0 insertions, 0 deletions