diff options
| author | Jeremy Fitzhardinge <jeremy@goop.org> | 2009-02-06 22:38:56 +0100 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-02-16 08:56:41 +0100 |
| commit | c99608637eac8834d830496c462c054137772122 (patch) | |
| tree | 2ed6f93a8e733a61a78d61f5181c79246f5458f9 /arch/x86/xen/multicalls.c | |
| parent | x86, xen: degrade BUG to WARN when multicall fails (diff) | |
| download | linux-c99608637eac8834d830496c462c054137772122.tar.xz linux-c99608637eac8834d830496c462c054137772122.zip | |
x86, xen: do multicall callbacks with interrupts disabled
We can't call the callbacks after enabling interrupts, as we may get a
nested multicall call, which would cause a great deal of havok.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/xen/multicalls.c')
| -rw-r--r-- | arch/x86/xen/multicalls.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c index 6cffd5532b91..8bff7e7c290b 100644 --- a/arch/x86/xen/multicalls.c +++ b/arch/x86/xen/multicalls.c @@ -170,8 +170,6 @@ void xen_mc_flush(void) } else BUG_ON(b->argidx != 0); - local_irq_restore(flags); - for (i = 0; i < b->cbidx; i++) { struct callback *cb = &b->callbacks[i]; @@ -179,6 +177,8 @@ void xen_mc_flush(void) } b->cbidx = 0; + local_irq_restore(flags); + WARN_ON(ret); } |