diff options
| author | Joerg Roedel <joerg.roedel@amd.com> | 2010-03-08 14:20:07 +0100 |
|---|---|---|
| committer | Joerg Roedel <joerg.roedel@amd.com> | 2010-03-08 14:20:07 +0100 |
| commit | 8b408fe4f853dcfa18d133aa4cf1d7546b4c3870 (patch) | |
| tree | 1eaa55a03e58f8499ac653c149dd12985129137d /arch/x86 | |
| parent | x86/amd-iommu: Report errors in acpi parsing functions upstream (diff) | |
| download | linux-8b408fe4f853dcfa18d133aa4cf1d7546b4c3870.tar.xz linux-8b408fe4f853dcfa18d133aa4cf1d7546b4c3870.zip | |
x86/amd-iommu: Use helper function to destroy domain
In the amd_iommu_domain_destroy the protection_domain_free
function is partly reimplemented. The 'partly' is the bug
here because the domain is not deleted from the domain list.
This results in use-after-free errors and data-corruption.
Fix it by just using protection_domain_free instead.
Cc: stable@kernel.org
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Diffstat (limited to 'arch/x86')
| -rw-r--r-- | arch/x86/kernel/amd_iommu.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c index 0c0425436a73..b06f29e275e9 100644 --- a/arch/x86/kernel/amd_iommu.c +++ b/arch/x86/kernel/amd_iommu.c @@ -2380,9 +2380,7 @@ static void amd_iommu_domain_destroy(struct iommu_domain *dom) free_pagetable(domain); - domain_id_free(domain->id); - - kfree(domain); + protection_domain_free(domain); dom->priv = NULL; } |