diff options
author | Sean Christopherson <seanjc@google.com> | 2023-05-13 01:31:27 +0200 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2023-05-19 19:56:25 +0200 |
commit | e0ceec221f62deb5d6c32c0327030028d3db5f27 (patch) | |
tree | c87a2c6244ffa52ec175c2f60d022c7d1c0900f2 /arch/x86 | |
parent | KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown (diff) | |
download | linux-e0ceec221f62deb5d6c32c0327030028d3db5f27.tar.xz linux-e0ceec221f62deb5d6c32c0327030028d3db5f27.zip |
KVM: Don't enable hardware after a restart/shutdown is initiated
Reject hardware enabling, i.e. VM creation, if a restart/shutdown has
been initiated to avoid re-enabling hardware between kvm_reboot() and
machine_{halt,power_off,restart}(). The restart case is especially
problematic (for x86) as enabling VMX (or clearing GIF in KVM_RUN on
SVM) blocks INIT, which results in the restart/reboot hanging as BIOS
is unable to wake and rendezvous with APs.
Note, this bug, and the original issue that motivated the addition of
kvm_reboot(), is effectively limited to a forced reboot, e.g. `reboot -f`.
In a "normal" reboot, userspace will gracefully teardown userspace before
triggering the kernel reboot (modulo bugs, errors, etc), i.e. any process
that might do ioctl(KVM_CREATE_VM) is long gone.
Fixes: 8e1c18157d87 ("KVM: VMX: Disable VMX when system shutdown")
Signed-off-by: Sean Christopherson <seanjc@google.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Message-Id: <20230512233127.804012-3-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch/x86')
0 files changed, 0 insertions, 0 deletions