summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorAtul Dahiya <atul.dahiya@samsung.com>2010-10-08 14:00:02 +0200
committerKukjin Kim <kgene.kim@samsung.com>2010-10-18 11:33:04 +0200
commit3d4af5cac77f8d4f7422b1d00cb9e67000f94301 (patch)
treed1bb6cb64454c6e7d5e550779cbcabe9726a7c26 /arch
parentARM: S5P64X0: Replace the 6440 system device class definition with 64x0 (diff)
downloadlinux-3d4af5cac77f8d4f7422b1d00cb9e67000f94301.tar.xz
linux-3d4af5cac77f8d4f7422b1d00cb9e67000f94301.zip
ARM: S5P64X0: Fix GPIO rbank support
The patch removes s3c_gpio_lock/unlock to avoid acquiring the lock recursively as lock is already acquired by calling function. Signed-off-by: Atul Dahiya <atul.dahiya@samsung.com> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com> [kgene.kim@samsung.com: removed useless variable due to this] Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
Diffstat (limited to 'arch')
-rw-r--r--arch/arm/mach-s5p64x0/gpio.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/arch/arm/mach-s5p64x0/gpio.c b/arch/arm/mach-s5p64x0/gpio.c
index 131eefe0c9f2..39159dd5a29a 100644
--- a/arch/arm/mach-s5p64x0/gpio.c
+++ b/arch/arm/mach-s5p64x0/gpio.c
@@ -132,7 +132,6 @@ int s5p64x0_gpio_setcfg_4bit_rbank(struct s3c_gpio_chip *chip,
{
void __iomem *reg = chip->base;
unsigned int shift;
- unsigned long flags;
u32 con;
switch (off) {
@@ -158,15 +157,11 @@ int s5p64x0_gpio_setcfg_4bit_rbank(struct s3c_gpio_chip *chip,
cfg <<= shift;
}
- s3c_gpio_lock(chip, flags);
-
con = __raw_readl(reg);
con &= ~(0xf << shift);
con |= cfg;
__raw_writel(con, reg);
- s3c_gpio_unlock(chip, flags);
-
return 0;
}