diff options
| author | Paul Walmsley <paul@pwsan.com> | 2012-04-13 14:34:28 +0200 |
|---|---|---|
| committer | Paul Walmsley <paul@pwsan.com> | 2012-04-13 14:34:28 +0200 |
| commit | 355f8eee48134ba10ca81664ee90eeb240f5f928 (patch) | |
| tree | 07b0cdc9f383b6e32616c49c595a768342eb75c1 /arch | |
| parent | ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus (diff) | |
| download | linux-355f8eee48134ba10ca81664ee90eeb240f5f928.tar.xz linux-355f8eee48134ba10ca81664ee90eeb240f5f928.zip | |
ARM: OMAP2+: GPMC: resolve type-conversion warning from sparse
arch/arm/mach-omap2/gpmc.c passes a return value from ioremap() as the
fifth argument to request_irq() without casting it. This causes
sparse to generate the following warning:
arch/arm/mach-omap2/gpmc.c:759:63: warning: incorrect type in argument 5 (different address spaces)
arch/arm/mach-omap2/gpmc.c:759:63: expected void *dev
arch/arm/mach-omap2/gpmc.c:759:63: got void [noderef] <asn:2>*static [toplevel] [assigned] gpmc_base
It turns out that it's not necessary to pass this. gpmc_base is a
file-scoped static variable, the ISR is located in the same file ... and
the ISR doesn't even touch the passed-in variable. So, just replace it with
NULL in request_irq().
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/arm/mach-omap2/gpmc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 00d510858e28..580e684e8825 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach-omap2/gpmc.c @@ -755,8 +755,7 @@ static int __init gpmc_init(void) irq++; } - ret = request_irq(gpmc_irq, - gpmc_handle_irq, IRQF_SHARED, "gpmc", gpmc_base); + ret = request_irq(gpmc_irq, gpmc_handle_irq, IRQF_SHARED, "gpmc", NULL); if (ret) pr_err("gpmc: irq-%d could not claim: err %d\n", gpmc_irq, ret); |