diff options
author | Paul Gortmaker <paul.gortmaker@windriver.com> | 2015-05-02 02:08:21 +0200 |
---|---|---|
committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2015-06-16 20:12:34 +0200 |
commit | 1206f53589237b7e00b9b0a4e42815f14aedad2d (patch) | |
tree | 7d2e250e64ea078a986029884c33a0bc349249c5 /arch | |
parent | netfilter: don't use module_init/exit in core IPV4 code (diff) | |
download | linux-1206f53589237b7e00b9b0a4e42815f14aedad2d.tar.xz linux-1206f53589237b7e00b9b0a4e42815f14aedad2d.zip |
x86: don't use module_init for non-modular core bootflag code
The bootflag.o is obj-y (always built in). It will never be
modular, so using module_init as an alias for __initcall is
somewhat misleading.
Fix this up now, so that we can relocate module_init from
init.h into module.h in the future. If we don't do this, we'd
have to add module.h to obviously non-modular code, and that
would be a worse thing.
Note that direct use of __initcall is discouraged, vs. one
of the priority categorized subgroups. As __initcall gets
mapped onto device_initcall, our use of arch_initcall (which
makes sense for arch code) will thus change this registration
from level 6-device to level 3-arch (i.e. slightly earlier).
However no observable impact of that small difference has
been observed during testing, or is expected.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/x86/kernel/bootflag.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/bootflag.c b/arch/x86/kernel/bootflag.c index 5de7f4c56971..52c8e3c7789d 100644 --- a/arch/x86/kernel/bootflag.c +++ b/arch/x86/kernel/bootflag.c @@ -98,4 +98,4 @@ static int __init sbf_init(void) return 0; } -module_init(sbf_init); +arch_initcall(sbf_init); |