summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2017-11-15 13:14:58 +0100
committerJani Nikula <jani.nikula@intel.com>2017-11-21 10:39:56 +0100
commit6e068270b7883836e4717e262d96d1c43690862a (patch)
treeb2c688b2d592c59c87a184bd0029326e2cb87e80 /arch
parentdrm/i915/gvt: ensure -ve return value is handled correctly (diff)
downloadlinux-6e068270b7883836e4717e262d96d1c43690862a.tar.xz
linux-6e068270b7883836e4717e262d96d1c43690862a.zip
drm/i915: Clear breadcrumb node when cancelling signaling
When we call intel_engine_cancel_signaling() to stop reporting when a request is completed via an asynchronous signal, we remove that request from the breadcrumb wait queue. However, we may be concurrently processing that request in the signaler itself, the actual operations on the request's node itself are serialised but we do not actually clear the waiter after removing it from the tree allowing both parties to attempt to do so and corrupting the rbtree. (Previously removing from the breadcrumb wait queue could only be done on behalf of i915_wait_request, so this race could not happen). Reported-by: "He, Bo" <bo.he@intel.com> Fixes: 9eb143bbec7d ("drm/i915: Allow a request to be cancelled") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: "He, Bo" <bo.he@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: MichaƂ Winiarski <michal.winiarski@intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171115121458.24655-1-chris@chris-wilson.co.uk Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> (cherry picked from commit c534612e780c4a2c8ef5bfc11583c7d58436baca) Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions