diff options
author | David Rivshin <drivshin@allworx.com> | 2015-12-17 05:02:10 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-12-18 20:46:05 +0100 |
commit | f1eea5c15ae799a1291f0f481fa3ea09be913fa9 (patch) | |
tree | c2c7b0b3aeeb9410ac2dd1ef6c14055bd0e9c139 /arch | |
parent | ethernet:ti:cpsw: fix phy identification with multiple slaves on fixed-phy (diff) | |
download | linux-f1eea5c15ae799a1291f0f481fa3ea09be913fa9.tar.xz linux-f1eea5c15ae799a1291f0f481fa3ea09be913fa9.zip |
drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY
Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: Add
support for fixed-link PHY") did not parse the "phy-mode" property in
the case of a fixed-link PHY, leaving slave_data->phy_if with its default
of PHY_INTERFACE_MODE_NA(0). This later gets passed to phy_connect() in
cpsw_slave_open(), and eventually to cpsw_phy_sel() where it hits a default
case that configures the MAC for MII mode.
The user visible symptom is that while kernel log messages seem to indicate
that the interface is set up, there is no network communication. Eventually
a watchdog error occurs:
NETDEV WATCHDOG: eth0 (cpsw): transmit queue 0 timed out
Fixes: 1f71e8c96fc6 ("drivers: net: cpsw: Add support for fixed-link PHY")
Signed-off-by: David Rivshin <drivshin@allworx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions