diff options
| author | David S. Miller <davem@davemloft.net> | 2009-11-24 01:38:56 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-11-24 01:38:56 +0100 |
| commit | bffbc94a4d2c1769c3826fceddd2dbb75e72c80b (patch) | |
| tree | 3e4cce10f16f57b038ae5fa590c9ac4337385f1e /arch | |
| parent | sparc: Move of_set_property_mutex acquisition outside of devtree_lock grab. (diff) | |
| download | linux-bffbc94a4d2c1769c3826fceddd2dbb75e72c80b.tar.xz linux-bffbc94a4d2c1769c3826fceddd2dbb75e72c80b.zip | |
sparc64: Fix definition of VMEMMAP_SIZE.
This was the cause of various boot failures on V480, V880, etc.
systems.
Kernel image memory was being overwritten because the vmemmap[]
array was being sized to small. So if you had physical memory
addresses past a certain point, the early bootup would spam
all over variables in the kernel data section.
The vmemmap mappings map page structs, not page struct pointers.
And that was the key thinko in the macro definition.
This was fixable thanks to the help, reports, and tireless patience
of Hermann Lauer.
Reported-by: Hermann Lauer <Hermann.Lauer@iwr.uni-heidelberg.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/sparc/mm/init_64.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/sparc/mm/init_64.h b/arch/sparc/mm/init_64.h index c2f772dbd556..77d1b313e344 100644 --- a/arch/sparc/mm/init_64.h +++ b/arch/sparc/mm/init_64.h @@ -45,7 +45,7 @@ extern void free_initmem(void); #define VMEMMAP_ALIGN(x) (((x)+VMEMMAP_CHUNK-1UL)&VMEMMAP_CHUNK_MASK) #define VMEMMAP_SIZE ((((1UL << MAX_PHYSADDR_BITS) >> PAGE_SHIFT) * \ - sizeof(struct page *)) >> VMEMMAP_CHUNK_SHIFT) + sizeof(struct page)) >> VMEMMAP_CHUNK_SHIFT) extern unsigned long vmemmap_table[VMEMMAP_SIZE]; #endif |