diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2018-09-08 12:07:26 +0200 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2018-09-08 12:12:40 +0200 |
| commit | 47b7360ce563e18c524ce92b55fb4da72b3b3578 (patch) | |
| tree | ef6fae9f2718dca7d22a4689f752d638b0844aea /arch | |
| parent | x86/process: Don't mix user/kernel regs in 64bit __show_regs() (diff) | |
| download | linux-47b7360ce563e18c524ce92b55fb4da72b3b3578.tar.xz linux-47b7360ce563e18c524ce92b55fb4da72b3b3578.zip | |
x86/apic/vector: Make error return value negative
activate_managed() returns EINVAL instead of -EINVAL in case of
error. While this is unlikely to happen, the positive return value would
cause further malfunction at the call site.
Fixes: 2db1f959d9dc ("x86/vector: Handle managed interrupts proper")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/x86/kernel/apic/vector.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c index 9f148e3d45b4..7654febd5102 100644 --- a/arch/x86/kernel/apic/vector.c +++ b/arch/x86/kernel/apic/vector.c @@ -413,7 +413,7 @@ static int activate_managed(struct irq_data *irqd) if (WARN_ON_ONCE(cpumask_empty(vector_searchmask))) { /* Something in the core code broke! Survive gracefully */ pr_err("Managed startup for irq %u, but no CPU\n", irqd->irq); - return EINVAL; + return -EINVAL; } ret = assign_managed_vector(irqd, vector_searchmask); |