summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorMarc Zyngier <maz@kernel.org>2020-03-10 19:49:20 +0100
committerMarc Zyngier <maz@kernel.org>2020-03-16 16:48:54 +0100
commitad00a325a09791f4637bf5d2ec627ed2c292653e (patch)
tree27d84735fa3a482c96944f0568f4293bc1d08cc7 /arch
parentirqchip/atmel-aic5: Fix irq_retrigger callback return value (diff)
downloadlinux-ad00a325a09791f4637bf5d2ec627ed2c292653e.tar.xz
linux-ad00a325a09791f4637bf5d2ec627ed2c292653e.zip
ARM: sa1111: Fix irq_retrigger callback return value
The irq_retrigger callback is supposed to return 0 when retrigger has failed, and a non-zero value otherwise. Tell the core code that the driver has succedded in using the HW to retrigger the interrupt (if ever). Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20200310184921.23552-4-maz@kernel.org
Diffstat (limited to 'arch')
-rw-r--r--arch/arm/common/sa1111.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
index 947ef7981d92..c98ebae1aeac 100644
--- a/arch/arm/common/sa1111.c
+++ b/arch/arm/common/sa1111.c
@@ -302,10 +302,13 @@ static int sa1111_retrigger_irq(struct irq_data *d)
break;
}
- if (i == 8)
+ if (i == 8) {
pr_err("Danger Will Robinson: failed to re-trigger IRQ%d\n",
d->irq);
- return i == 8 ? -1 : 0;
+ return 0;
+ }
+
+ return 1;
}
static int sa1111_type_irq(struct irq_data *d, unsigned int flags)