diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-02-05 08:37:33 +0100 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2015-02-06 07:44:12 +0100 |
commit | 59c816c1f24df0204e01851431d3bab3eb76719c (patch) | |
tree | 34aaf6575d4b894b4025d535818ae1437bb08401 /block/blk-core.c | |
parent | vhost/scsi: Global tcm_vhost -> vhost_scsi rename (diff) | |
download | linux-59c816c1f24df0204e01851431d3bab3eb76719c.tar.xz linux-59c816c1f24df0204e01851431d3bab3eb76719c.zip |
vhost/scsi: potential memory corruption
This code in vhost_scsi_make_tpg() is confusing because we limit "tpgt"
to UINT_MAX but the data type of "tpg->tport_tpgt" and that is a u16.
I looked at the context and it turns out that in
vhost_scsi_set_endpoint(), "tpg->tport_tpgt" is used as an offset into
the vs_tpg[] array which has VHOST_SCSI_MAX_TARGET (256) elements so
anything higher than 255 then it is invalid. I have made that the limit
now.
In vhost_scsi_send_evt() we mask away values higher than 255, but now
that the limit has changed, we don't need the mask.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'block/blk-core.c')
0 files changed, 0 insertions, 0 deletions