diff options
author | Ming Lei <ming.lei@redhat.com> | 2019-04-30 03:52:29 +0200 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-05-04 15:24:11 +0200 |
commit | 662156641bc409a28fa313fca1a755105425d278 (patch) | |
tree | 555c59d4df3bd2500b82bf48c2a0056adf977a32 /block/blk-core.c | |
parent | blk-mq: move cancel of hctx->run_work into blk_mq_hw_sysfs_release (diff) | |
download | linux-662156641bc409a28fa313fca1a755105425d278.tar.xz linux-662156641bc409a28fa313fca1a755105425d278.zip |
block: don't drain in-progress dispatch in blk_cleanup_queue()
Now freeing hw queue resource is moved to hctx's release handler,
we don't need to worry about the race between blk_cleanup_queue and
run queue any more.
So don't drain in-progress dispatch in blk_cleanup_queue().
This is basically revert of c2856ae2f315 ("blk-mq: quiesce queue before
freeing queue").
Cc: Dongli Zhang <dongli.zhang@oracle.com>
Cc: James Smart <james.smart@broadcom.com>
Cc: Bart Van Assche <bart.vanassche@wdc.com>
Cc: linux-scsi@vger.kernel.org,
Cc: Martin K . Petersen <martin.petersen@oracle.com>,
Cc: Christoph Hellwig <hch@lst.de>,
Cc: James E . J . Bottomley <jejb@linux.vnet.ibm.com>,
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-core.c')
-rw-r--r-- | block/blk-core.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/block/blk-core.c b/block/blk-core.c index 6722b24a1182..419d600e6637 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -339,18 +339,6 @@ void blk_cleanup_queue(struct request_queue *q) blk_queue_flag_set(QUEUE_FLAG_DEAD, q); - /* - * make sure all in-progress dispatch are completed because - * blk_freeze_queue() can only complete all requests, and - * dispatch may still be in-progress since we dispatch requests - * from more than one contexts. - * - * We rely on driver to deal with the race in case that queue - * initialization isn't done. - */ - if (queue_is_mq(q) && blk_queue_init_done(q)) - blk_mq_quiesce_queue(q); - /* for synchronous bio-based driver finish in-flight integrity i/o */ blk_flush_integrity(); |