diff options
| author | David Hildenbrand <dahi@linux.vnet.ibm.com> | 2014-09-18 11:04:31 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2014-09-22 19:55:14 +0200 |
| commit | 683d0e126232d898a481daa3a4ca032c2b1a9660 (patch) | |
| tree | ce6bf69626d6b1b11cd3fb69bb31db506fe77704 /block/blk-exec.c | |
| parent | blk-mq: request deadline must be visible before marking rq as started (diff) | |
| download | linux-683d0e126232d898a481daa3a4ca032c2b1a9660.tar.xz linux-683d0e126232d898a481daa3a4ca032c2b1a9660.zip | |
blk-mq: Avoid race condition with uninitialized requests
This patch should fix the bug reported in
https://lkml.org/lkml/2014/9/11/249.
We have to initialize at least the atomic_flags and the cmd_flags when
allocating storage for the requests.
Otherwise blk_mq_timeout_check() might dereference uninitialized
pointers when racing with the creation of a request.
Also move the reset of cmd_flags for the initializing code to the point
where a request is freed. So we will never end up with pending flush
request indicators that might trigger dereferences of invalid pointers
in blk_mq_timeout_check().
Cc: stable@vger.kernel.org
Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Reported-by: Paulo De Rezende Pinatti <ppinatti@linux.vnet.ibm.com>
Tested-by: Paulo De Rezende Pinatti <ppinatti@linux.vnet.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block/blk-exec.c')
0 files changed, 0 insertions, 0 deletions