summaryrefslogtreecommitdiffstats
path: root/block/blk-flush.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2023-05-19 06:40:49 +0200
committerJens Axboe <axboe@kernel.dk>2023-05-20 03:52:29 +0200
commit1e82fadfc6b96ca79f69d0bcf938d31032bb43d2 (patch)
tree5f26eefdc90001bd959e8a0edfbf1f4cafb04b16 /block/blk-flush.c
parentblk-mq: defer to the normal submission path for post-flush requests (diff)
downloadlinux-1e82fadfc6b96ca79f69d0bcf938d31032bb43d2.tar.xz
linux-1e82fadfc6b96ca79f69d0bcf938d31032bb43d2.zip
blk-mq: do not do head insertions post-pre-flush commands
blk_flush_complete_seq currently queues requests that write data after a pre-flush from the flush state machine at the head of the queue. This doesn't really make sense, as the original request bypassed all queue lists by directly diverting to blk_insert_flush from blk_mq_submit_bio. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Link: https://lore.kernel.org/r/20230519044050.107790-7-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-flush.c')
-rw-r--r--block/blk-flush.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-flush.c b/block/blk-flush.c
index 7121f9ad0762..f407a5950317 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -188,7 +188,7 @@ static void blk_flush_complete_seq(struct request *rq,
case REQ_FSEQ_DATA:
list_move_tail(&rq->flush.list, &fq->flush_data_in_flight);
- blk_mq_add_to_requeue_list(rq, BLK_MQ_INSERT_AT_HEAD);
+ blk_mq_add_to_requeue_list(rq, 0);
blk_mq_kick_requeue_list(q);
break;