diff options
| author | Omar Sandoval <osandov@fb.com> | 2017-05-04 09:31:26 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2017-05-04 16:23:20 +0200 |
| commit | 71b90511cb170dd3e13b640cc1a453b2dd92e023 (patch) | |
| tree | fa2a1fd30e70b8fee6236864cb15e0b318072d0d /block/blk-mq-debugfs.c | |
| parent | blk-mq-debugfs: error on long write to queue "state" file (diff) | |
| download | linux-71b90511cb170dd3e13b640cc1a453b2dd92e023.tar.xz linux-71b90511cb170dd3e13b640cc1a453b2dd92e023.zip | |
blk-mq-debugfs: don't open code strstrip()
Slightly more readable, plus we also strip leading spaces.
Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to '')
| -rw-r--r-- | block/blk-mq-debugfs.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index 2a19237455d4..109ae9f3d400 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -111,17 +111,16 @@ static ssize_t blk_queue_flags_store(struct file *file, const char __user *buf, size_t count, loff_t *ppos) { struct request_queue *q = file_inode(file)->i_private; - char op[16] = { }, *s; + char opbuf[16] = { }, *op; - if (count >= sizeof(op)) { + if (count >= sizeof(opbuf)) { pr_err("%s: operation too long\n", __func__); goto inval; } - if (copy_from_user(op, buf, count)) + if (copy_from_user(opbuf, buf, count)) return -EFAULT; - s = op; - strsep(&s, " \t\n"); /* strip trailing whitespace */ + op = strstrip(opbuf); if (strcmp(op, "run") == 0) { blk_mq_run_hw_queues(q, true); } else if (strcmp(op, "start") == 0) { |