diff options
| author | Jianchao Wang <jianchao.w.wang@oracle.com> | 2018-12-14 02:28:19 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-12-16 16:33:57 +0100 |
| commit | 5b7a6f128aad761b471ca0ff620b4841b38e596f (patch) | |
| tree | 2feb1d41477244ea269220f98c648ceb742e28a3 /block/blk-mq-sched.c | |
| parent | blk-mq: refactor the code of issue request directly (diff) | |
| download | linux-5b7a6f128aad761b471ca0ff620b4841b38e596f.tar.xz linux-5b7a6f128aad761b471ca0ff620b4841b38e596f.zip | |
blk-mq: issue directly with bypass 'false' in blk_mq_sched_insert_requests
It is not necessary to issue request directly with bypass 'true'
in blk_mq_sched_insert_requests and handle the non-issued requests
itself. Just set bypass to 'false' and let blk_mq_try_issue_directly
handle them totally. Remove the blk_rq_can_direct_dispatch check,
because blk_mq_try_issue_directly can handle it well.If request is
direct-issued unsuccessfully, insert the reset.
Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-mq-sched.c')
| -rw-r--r-- | block/blk-mq-sched.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c index f096d8989773..5b4d52d9cba2 100644 --- a/block/blk-mq-sched.c +++ b/block/blk-mq-sched.c @@ -417,12 +417,10 @@ void blk_mq_sched_insert_requests(struct blk_mq_hw_ctx *hctx, * busy in case of 'none' scheduler, and this way may save * us one extra enqueue & dequeue to sw queue. */ - if (!hctx->dispatch_busy && !e && !run_queue_async) { + if (!hctx->dispatch_busy && !e && !run_queue_async) blk_mq_try_issue_list_directly(hctx, list); - if (list_empty(list)) - return; - } - blk_mq_insert_requests(hctx, ctx, list); + else + blk_mq_insert_requests(hctx, ctx, list); } blk_mq_run_hw_queue(hctx, run_queue_async); |