diff options
| author | Ming Lei <ming.lei@redhat.com> | 2020-06-30 12:24:59 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-06-30 15:51:48 +0200 |
| commit | bbdb3c5d94d079ab4c6eaf9ac0d4f6813f1c0327 (patch) | |
| tree | 5745a489d25615bff9665dc6253d3d44be7ce5da /block/blk-mq.c | |
| parent | blk-mq: move getting driver tag and budget into one helper (diff) | |
| download | linux-bbdb3c5d94d079ab4c6eaf9ac0d4f6813f1c0327.tar.xz linux-bbdb3c5d94d079ab4c6eaf9ac0d4f6813f1c0327.zip | |
blk-mq: remove dead check from blk_mq_dispatch_rq_list
When BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE is returned from
.queue_rq, the 'list' variable always holds this rq which isn't
queued to LLD successfully.
So blk_mq_dispatch_rq_list() always returns false from the branch
of '!list_empty(list)'.
No functional change.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Tested-by: Baolin Wang <baolin.wang7@gmail.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Baolin Wang <baolin.wang7@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-mq.c')
| -rw-r--r-- | block/blk-mq.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index 3e370f5bc40a..a80cb6ecc9d9 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1426,13 +1426,6 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *hctx, struct list_head *list, } else blk_mq_update_dispatch_busy(hctx, false); - /* - * If the host/device is unable to accept more work, inform the - * caller of that. - */ - if (ret == BLK_STS_RESOURCE || ret == BLK_STS_DEV_RESOURCE) - return false; - return (queued + errors) != 0; } |