summaryrefslogtreecommitdiffstats
path: root/block/blk-rq-qos.h
diff options
context:
space:
mode:
authorJens Axboe <axboe@kernel.dk>2021-10-16 04:06:18 +0200
committerJens Axboe <axboe@kernel.dk>2021-10-18 16:50:47 +0200
commit90b8faa0e8de1b02b619fb33f6c6e1e13e7d1d70 (patch)
tree2cb9222d749ed8f3d8f2aaedd7ca28aba9476c3c /block/blk-rq-qos.h
parentblock: improve layout of struct request (diff)
downloadlinux-90b8faa0e8de1b02b619fb33f6c6e1e13e7d1d70.tar.xz
linux-90b8faa0e8de1b02b619fb33f6c6e1e13e7d1d70.zip
block: only mark bio as tracked if it really is tracked
We set BIO_TRACKED unconditionally when rq_qos_throttle() is called, even though we may not even have an rq_qos handler. Only mark it as TRACKED if it really is potentially tracked. This saves considerable time for the case where the bio isn't tracked: 2.64% -1.65% [kernel.vmlinux] [k] bio_endio Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-rq-qos.h')
-rw-r--r--block/blk-rq-qos.h5
1 files changed, 3 insertions, 2 deletions
diff --git a/block/blk-rq-qos.h b/block/blk-rq-qos.h
index f000f83e0621..3cfbc8668cba 100644
--- a/block/blk-rq-qos.h
+++ b/block/blk-rq-qos.h
@@ -189,9 +189,10 @@ static inline void rq_qos_throttle(struct request_queue *q, struct bio *bio)
* BIO_TRACKED lets controllers know that a bio went through the
* normal rq_qos path.
*/
- bio_set_flag(bio, BIO_TRACKED);
- if (q->rq_qos)
+ if (q->rq_qos) {
+ bio_set_flag(bio, BIO_TRACKED);
__rq_qos_throttle(q->rq_qos, bio);
+ }
}
static inline void rq_qos_track(struct request_queue *q, struct request *rq,