diff options
| author | Dennis Zhou <dennis@kernel.org> | 2018-12-05 18:10:31 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-12-08 06:26:37 +0100 |
| commit | 5cdf2e3fea5ee37b66842d76a9b06e6dac0b933d (patch) | |
| tree | b460ef1ba02562982e2f000e704ce7214be4d5f3 /block/blk-throttle.c | |
| parent | dm: set the static flush bio device on demand (diff) | |
| download | linux-5cdf2e3fea5ee37b66842d76a9b06e6dac0b933d.tar.xz linux-5cdf2e3fea5ee37b66842d76a9b06e6dac0b933d.zip | |
blkcg: associate blkg when associating a device
Previously, blkg association was handled by controller specific code in
blk-throttle and blk-iolatency. However, because a blkg represents a
relationship between a blkcg and a request_queue, it makes sense to keep
the blkg->q and bio->bi_disk->queue consistent.
This patch moves association into the bio_set_dev macro(). This should
cover the majority of cases where the device is set/changed keeping the
two pointers consistent. Fallback code is added to
blkcg_bio_issue_check() to catch any missing paths.
Signed-off-by: Dennis Zhou <dennis@kernel.org>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-throttle.c')
| -rw-r--r-- | block/blk-throttle.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 228c3a007ebc..1c6529df2002 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -2118,7 +2118,6 @@ static inline void throtl_update_latency_buckets(struct throtl_data *td) static void blk_throtl_assoc_bio(struct bio *bio) { #ifdef CONFIG_BLK_DEV_THROTTLING_LOW - bio_associate_blkg(bio); bio_issue_init(&bio->bi_issue, bio_sectors(bio)); #endif } |