diff options
| author | Tejun Heo <tj@kernel.org> | 2012-06-05 05:40:56 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2012-06-25 11:53:50 +0200 |
| commit | 7f4b35d155a5f9e5748539a79558533aa08d6a81 (patch) | |
| tree | 9e26e52852cd6b364d413b02b9c5379c5372be7e /block/blk-throttle.c | |
| parent | block: refactor get_request[_wait]() (diff) | |
| download | linux-7f4b35d155a5f9e5748539a79558533aa08d6a81.tar.xz linux-7f4b35d155a5f9e5748539a79558533aa08d6a81.zip | |
block: allocate io_context upfront
Block layer very lazy allocation of ioc. It waits until the moment
ioc is absolutely necessary; unfortunately, that time could be inside
queue lock and __get_request() performs unlock - try alloc - retry
dancing.
Just allocate it up-front on entry to block layer. We're not saving
the rain forest by deferring it to the last possible moment and
complicating things unnecessarily.
This patch is to prepare for further updates to request allocation
path.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-throttle.c')
| -rw-r--r-- | block/blk-throttle.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 5b0659512047..e287c19908c8 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1123,9 +1123,6 @@ bool blk_throtl_bio(struct request_queue *q, struct bio *bio) goto out; } - /* bio_associate_current() needs ioc, try creating */ - create_io_context(GFP_ATOMIC, q->node); - /* * A throtl_grp pointer retrieved under rcu can be used to access * basic fields like stats and io rates. If a group has no rules, |