diff options
| author | Tejun Heo <tj@kernel.org> | 2015-08-18 23:55:28 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-08-19 00:49:18 +0200 |
| commit | 20386ce0143899ccb5bcbda714436a82d3029f33 (patch) | |
| tree | f1fe9b3a30a3afce0ea20632b830007495d95b0a /block/cfq-iosched.c | |
| parent | blkcg: remove unnecessary NULL checks from __cfqg_set_weight_device() (diff) | |
| download | linux-20386ce0143899ccb5bcbda714436a82d3029f33.tar.xz linux-20386ce0143899ccb5bcbda714436a82d3029f33.zip | |
blkcg: refine error codes returned during blkcg configuration
blkcg currently returns -EINVAL for most errors which can be pretty
confusing given that the failure modes are quite varied. Update the
error returns so that
* -EINVAL only for syntactic errors.
* -ERANGE if the value is out of range.
* -ENODEV if the target device can't be found.
* -EOPNOTSUPP if the policy is not enabled on the target device.
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block/cfq-iosched.c')
| -rw-r--r-- | block/cfq-iosched.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index bcf40266bd0a..38277e3ce286 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -1755,7 +1755,7 @@ static ssize_t __cfqg_set_weight_device(struct kernfs_open_file *of, cfqg = blkg_to_cfqg(ctx.blkg); cfqgd = blkcg_to_cfqgd(blkcg); - ret = -EINVAL; + ret = -ERANGE; if (!ctx.v || (ctx.v >= CFQ_WEIGHT_MIN && ctx.v <= CFQ_WEIGHT_MAX)) { if (!is_leaf_weight) { cfqg->dev_weight = ctx.v; |