diff options
| author | Jan Kara <jack@suse.cz> | 2018-02-26 13:01:37 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-02-26 17:48:42 +0100 |
| commit | d52987b524ccd2e2165ddad9bcc087a6c3f5332c (patch) | |
| tree | 5eb0cdb9144279195e29ca3db846f95449756dcb /block/genhd.c | |
| parent | direct-io: Fix sleep in atomic due to sync AIO (diff) | |
| download | linux-d52987b524ccd2e2165ddad9bcc087a6c3f5332c.tar.xz linux-d52987b524ccd2e2165ddad9bcc087a6c3f5332c.zip | |
genhd: Fix leaked module reference for NVME devices
Commit 8ddcd653257c "block: introduce GENHD_FL_HIDDEN" added handling of
hidden devices to get_gendisk() but forgot to drop module reference
which is also acquired by get_disk(). Drop the reference as necessary.
Arguably the function naming here is misleading as put_disk() is *not*
the counterpart of get_disk() but let's fix that in the follow up
commit since that will be more intrusive.
Fixes: 8ddcd653257c18a669fcb75ee42c37054908e0d6
CC: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/genhd.c')
| -rw-r--r-- | block/genhd.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/block/genhd.c b/block/genhd.c index 88a53c188cb7..5098bffe6ba6 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -817,7 +817,10 @@ struct gendisk *get_gendisk(dev_t devt, int *partno) } if (disk && unlikely(disk->flags & GENHD_FL_HIDDEN)) { + struct module *owner = disk->fops->owner; + put_disk(disk); + module_put(owner); disk = NULL; } return disk; |