summaryrefslogtreecommitdiffstats
path: root/block/opal_proto.h
diff options
context:
space:
mode:
authorFlorian Westphal <fw@strlen.de>2020-01-08 10:59:38 +0100
committerPablo Neira Ayuso <pablo@netfilter.org>2020-01-08 23:31:46 +0100
commit22dad713b8a5ff488e07b821195270672f486eb2 (patch)
tree67112225e0ae6cef37c3bd450ef19eed88f140f2 /block/opal_proto.h
parentnetfilter: conntrack: dccp, sctp: handle null timeout argument (diff)
downloadlinux-22dad713b8a5ff488e07b821195270672f486eb2.tar.xz
linux-22dad713b8a5ff488e07b821195270672f486eb2.zip
netfilter: ipset: avoid null deref when IPSET_ATTR_LINENO is present
The set uadt functions assume lineno is never NULL, but it is in case of ip_set_utest(). syzkaller managed to generate a netlink message that calls this with LINENO attr present: general protection fault: 0000 [#1] PREEMPT SMP KASAN RIP: 0010:hash_mac4_uadt+0x1bc/0x470 net/netfilter/ipset/ip_set_hash_mac.c:104 Call Trace: ip_set_utest+0x55b/0x890 net/netfilter/ipset/ip_set_core.c:1867 nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229 netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477 nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563 pass a dummy lineno storage, its easier than patching all set implementations. This seems to be a day-0 bug. Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> Reported-by: syzbot+34bd2369d38707f3f4a7@syzkaller.appspotmail.com Fixes: a7b4f989a6294 ("netfilter: ipset: IP set core support") Signed-off-by: Florian Westphal <fw@strlen.de> Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'block/opal_proto.h')
0 files changed, 0 insertions, 0 deletions