summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorJosef Bacik <josef@toxicpanda.com>2018-07-31 18:39:02 +0200
committerJens Axboe <axboe@kernel.dk>2018-08-01 17:16:01 +0200
commit52a1199ccd426ad583ade4eb678b3b5846c58f43 (patch)
treec4de9b664eb8394617222ae6b65a1dc6a690af59 /block
parentblock/bsg-lib: use PTR_ERR_OR_ZERO to simplify the flow path (diff)
downloadlinux-52a1199ccd426ad583ade4eb678b3b5846c58f43.tar.xz
linux-52a1199ccd426ad583ade4eb678b3b5846c58f43.zip
blk-iolatency: fix blkg leak in timer_fn
At this point we have a ref on the blkg, we need to drop it if we don't have a iolat. Signed-off-by: Josef Bacik <josef@toxicpanda.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
-rw-r--r--block/blk-iolatency.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c
index bb59b2929e0d..b0dc4fc64b3e 100644
--- a/block/blk-iolatency.c
+++ b/block/blk-iolatency.c
@@ -627,7 +627,7 @@ static void blkiolatency_timer_fn(struct timer_list *t)
iolat = blkg_to_lat(blkg);
if (!iolat)
- continue;
+ goto next;
lat_info = &iolat->child_lat;
cookie = atomic_read(&lat_info->scale_cookie);