diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2018-07-10 17:21:34 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-07-10 20:26:09 +0200 |
| commit | 88b7210c81096c018f5836aff4749743c0d34623 (patch) | |
| tree | 903f498b0a692ad8dd3cb22f4232d04aff5cc201 /block | |
| parent | block/DAC960.c: fix defined but not used build warnings (diff) | |
| download | linux-88b7210c81096c018f5836aff4749743c0d34623.tar.xz linux-88b7210c81096c018f5836aff4749743c0d34623.zip | |
block: iolatency: avoid 64-bit division
On 32-bit architectures, dividing a 64-bit number needs to use the
do_div() function or something like it to avoid a link failure:
block/blk-iolatency.o: In function `iolatency_prfill_limit':
blk-iolatency.c:(.text+0x8cc): undefined reference to `__aeabi_uldivmod'
Using div_u64() gives us the best output and avoids the need for an
explicit cast.
Fixes: d70675121546 ("block: introduce blk-iolatency io controller")
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-iolatency.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c index a35a1f580337..56ddb2c68752 100644 --- a/block/blk-iolatency.c +++ b/block/blk-iolatency.c @@ -798,8 +798,7 @@ static u64 iolatency_prfill_limit(struct seq_file *sf, if (!dname || !iolat->min_lat_nsec) return 0; seq_printf(sf, "%s target=%llu\n", - dname, - (unsigned long long)iolat->min_lat_nsec / NSEC_PER_USEC); + dname, div_u64(iolat->min_lat_nsec, NSEC_PER_USEC)); return 0; } |