summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorWilly Tarreau <w@1wt.eu>2020-03-01 20:55:55 +0100
committerJens Axboe <axboe@kernel.dk>2020-03-16 15:26:58 +0100
commite83995c9f84161900b80d337d6df358a7803870a (patch)
treed62f4d1663049593491b8988072aba7ff71f4b39 /block
parentfloppy: separate the FDC's base address from its registers (diff)
downloadlinux-e83995c9f84161900b80d337d6df358a7803870a.tar.xz
linux-e83995c9f84161900b80d337d6df358a7803870a.zip
floppy: rename the global "fdc" variable to "current_fdc"
This is done in order to remove the confusion that arises at some places in the code where local variables or arguments shadow the global variable. It is already visible that some places are a bit awkward and iterate over the global variable, for the sole reason that they used to rely on it being named "fdc" in order to get the correct address when using FD_DOR. These ones are easy to spot by searching for "for (current_fdc...". Some more cleanup is definitely possible. For example "fdc_state[current_fdc].somefield" is used all over the code and would probably be better with "fdc_state->somefield" with fdc_state being set when current_fdc is assigned. This would require to pass the pointer to the current state instead of the current_fdc to the I/O functions. Link: https://lore.kernel.org/r/20200301195555.11154-7-w@1wt.eu Cc: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Denis Efremov <efremov@linux.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions