summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2017-09-07 13:54:35 +0200
committerJens Axboe <axboe@kernel.dk>2017-09-25 16:56:05 +0200
commitf507b54dccfd8000c517d740bc45f20c74532d18 (patch)
tree8b6d8fdbafe4dee31f597776c36834bd4d5601f1 /block
parentbrd: fix overflow in __brd_direct_access (diff)
downloadlinux-f507b54dccfd8000c517d740bc45f20c74532d18.tar.xz
linux-f507b54dccfd8000c517d740bc45f20c74532d18.zip
bsg-lib: don't free job in bsg_prepare_job
The job structure is allocated as part of the request, so we should not free it in the error path of bsg_prepare_job. Signed-off-by: Christoph Hellwig <hch@lst.de> Cc: stable@vger.kernel.org Reviewed-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
-rw-r--r--block/bsg-lib.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/block/bsg-lib.c b/block/bsg-lib.c
index c82408c7cc3c..dbddff8174e5 100644
--- a/block/bsg-lib.c
+++ b/block/bsg-lib.c
@@ -154,7 +154,6 @@ static int bsg_prepare_job(struct device *dev, struct request *req)
failjob_rls_rqst_payload:
kfree(job->request_payload.sg_list);
failjob_rls_job:
- kfree(job);
return -ENOMEM;
}