diff options
| author | Yu Kuai <yukuai3@huawei.com> | 2023-01-17 08:08:03 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2023-01-29 23:18:34 +0100 |
| commit | 235a5a83f637e32646cd004c9b580decf1225566 (patch) | |
| tree | c84b8330e382fe7cac8193b30e64fedeb12825cc /block | |
| parent | blk-iocost: check return value of match_u64() (diff) | |
| download | linux-235a5a83f637e32646cd004c9b580decf1225566.tar.xz linux-235a5a83f637e32646cd004c9b580decf1225566.zip | |
blk-iocost: don't allow to configure bio based device
iocost is based on rq_qos, which can only work for request based device,
thus it doesn't make sense to configure iocost for bio based device.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20230117070806.3857142-3-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-iocost.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/block/blk-iocost.c b/block/blk-iocost.c index 3b99c6a7a104..42a492096d3f 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -3187,6 +3187,11 @@ static ssize_t ioc_qos_write(struct kernfs_open_file *of, char *input, return PTR_ERR(bdev); disk = bdev->bd_disk; + if (!queue_is_mq(disk->queue)) { + ret = -EOPNOTSUPP; + goto err; + } + ioc = q_to_ioc(disk->queue); if (!ioc) { ret = blk_iocost_init(disk); @@ -3367,6 +3372,11 @@ static ssize_t ioc_cost_model_write(struct kernfs_open_file *of, char *input, return PTR_ERR(bdev); q = bdev_get_queue(bdev); + if (!queue_is_mq(q)) { + ret = -EOPNOTSUPP; + goto err; + } + ioc = q_to_ioc(q); if (!ioc) { ret = blk_iocost_init(bdev->bd_disk); |