summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2018-05-30 18:51:00 +0200
committerJens Axboe <axboe@kernel.dk>2018-05-30 19:31:34 +0200
commitd250bf4e776ff09d51c97f83c7a19f65a9e1c5a5 (patch)
tree8b0d1aff3030f70300bd2be35b279ae24a131f8e /block
parentnbd: clear DISCONNECT_REQUESTED flag once disconnection occurs. (diff)
downloadlinux-d250bf4e776ff09d51c97f83c7a19f65a9e1c5a5.tar.xz
linux-d250bf4e776ff09d51c97f83c7a19f65a9e1c5a5.zip
blk-mq: only iterate over inflight requests in blk_mq_tagset_busy_iter
We already check for started commands in all callbacks, but we should also protect against already completed commands. Do this by taking the checks to common code. Acked-by: Josef Bacik <josef@toxicpanda.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
-rw-r--r--block/blk-mq-tag.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index a4e58fc28a06..70356a2a11ab 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -271,7 +271,7 @@ static bool bt_tags_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data)
* test and set the bit before assining ->rqs[].
*/
rq = tags->rqs[bitnr];
- if (rq)
+ if (rq && blk_mq_rq_state(rq) == MQ_RQ_IN_FLIGHT)
iter_data->fn(rq, iter_data->data, reserved);
return true;