summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorArd Biesheuvel <ardb@kernel.org>2024-01-18 18:06:30 +0100
committerHerbert Xu <herbert@gondor.apana.org.au>2024-01-26 09:39:32 +0100
commitf722002441a1395d3e073f9fb5b6f1ab33ca9d66 (patch)
treef973c68cd7e4483b1f6bfc16489a6500ed3b4778 /block
parentcrypto: asymmetric_keys - remove redundant pointer secs (diff)
downloadlinux-f722002441a1395d3e073f9fb5b6f1ab33ca9d66.tar.xz
linux-f722002441a1395d3e073f9fb5b6f1ab33ca9d66.zip
crypto: arm64/aes-ccm - Revert "Rewrite skcipher walker loop"
This reverts commit 57ead1bf1c54, which updated the CCM code to only rely on walk.nbytes to check for failures returned from the skcipher walk API, mostly for the common good rather than to fix a particular problem in the code. This change introduces a problem of its own: the skcipher walk is started with the 'atomic' argument set to false, which means that the skcipher walk API is permitted to sleep. Subsequently, it invokes skcipher_walk_done() with preemption disabled on the final iteration of the loop. This appears to work by accident, but it is arguably a bad example, and providing a better example was the point of the original patch. Given that future changes to the CCM code will rely on the original behavior of entering the loop even for zero sized inputs, let's just revert this change entirely, and proceed from there. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions