summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorDinghao Liu <dinghao.liu@zju.edu.cn>2021-01-17 09:50:17 +0100
committerJens Axboe <axboe@kernel.dk>2021-01-25 05:35:58 +0100
commitef49d40b61a3e18a11edd5eb1c30b0183af9e850 (patch)
tree94db90b4918e9db8b9b9f0ccc8e6501c5d56dbae /block
parentblk-mq: test QUEUE_FLAG_HCTX_ACTIVE for sbitmap_shared in hctx_may_queue (diff)
downloadlinux-ef49d40b61a3e18a11edd5eb1c30b0183af9e850.tar.xz
linux-ef49d40b61a3e18a11edd5eb1c30b0183af9e850.zip
block: Fix an error handling in add_partition
Once we have called device_initialize(), we should use put_device() to give up the reference on error, just like what we have done on failure of device_add(). Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
-rw-r--r--block/partitions/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/partitions/core.c b/block/partitions/core.c
index e7d776db803b..23460cee9de5 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -384,7 +384,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,
err = blk_alloc_devt(bdev, &devt);
if (err)
- goto out_bdput;
+ goto out_put;
pdev->devt = devt;
/* delay uevent until 'holders' subdir is created */