summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorMaciej S. Szmigiero <mail@maciej.szmigiero.name>2018-08-15 23:56:45 +0200
committerJens Axboe <axboe@kernel.dk>2018-08-16 21:11:16 +0200
commitfc8ebd01deeb12728c83381f6ec923e4a192ffd3 (patch)
tree7233047c8a5d8c0925d62b9a59235c73996f0931 /block
parentblock, bfq: improve code of bfq_bfqq_charge_time (diff)
downloadlinux-fc8ebd01deeb12728c83381f6ec923e4a192ffd3.tar.xz
linux-fc8ebd01deeb12728c83381f6ec923e4a192ffd3.zip
block, bfq: return nbytes and not zero from struct cftype .write() method
The value that struct cftype .write() method returns is then directly returned to userspace as the value returned by write() syscall, so it should be the number of bytes actually written (or consumed) and not zero. Returning zero from write() syscall makes programs like /bin/echo or bash spin. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Fixes: e21b7a0b9887 ("block, bfq: add full hierarchical scheduling and cgroups support") Cc: stable@vger.kernel.org Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
-rw-r--r--block/bfq-cgroup.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index a9e8633388f4..58c6efa9f9a9 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -913,7 +913,8 @@ static ssize_t bfq_io_set_weight(struct kernfs_open_file *of,
if (ret)
return ret;
- return bfq_io_set_weight_legacy(of_css(of), NULL, weight);
+ ret = bfq_io_set_weight_legacy(of_css(of), NULL, weight);
+ return ret ?: nbytes;
}
#ifdef CONFIG_DEBUG_BLK_CGROUP