diff options
| author | Mike Christie <mchristi@redhat.com> | 2019-12-08 23:51:50 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2019-12-17 00:12:47 +0100 |
| commit | 1c05839aa973cfae8c3db964a21f9c0eef8fcc21 (patch) | |
| tree | 54a8008a6f4727e4ed19a8910068fd7ee67171bf /block | |
| parent | iocost: over-budget forced IOs should schedule async delay (diff) | |
| download | linux-1c05839aa973cfae8c3db964a21f9c0eef8fcc21.tar.xz linux-1c05839aa973cfae8c3db964a21f9c0eef8fcc21.zip | |
nbd: fix shutdown and recv work deadlock v2
This fixes a regression added with:
commit e9e006f5fcf2bab59149cb38a48a4817c1b538b4
Author: Mike Christie <mchristi@redhat.com>
Date: Sun Aug 4 14:10:06 2019 -0500
nbd: fix max number of supported devs
where we can deadlock during device shutdown. The problem occurs if
the recv_work's nbd_config_put occurs after nbd_start_device_ioctl has
returned and the userspace app has droppped its reference via closing
the device and running nbd_release. The recv_work nbd_config_put call
would then drop the refcount to zero and try to destroy the config which
would try to do destroy_workqueue from the recv work.
This patch just has nbd_start_device_ioctl do a flush_workqueue when it
wakes so we know after the ioctl returns running works have exited. This
also fixes a possible race where we could try to reuse the device while
old recv_works are still running.
Cc: stable@vger.kernel.org
Fixes: e9e006f5fcf2 ("nbd: fix max number of supported devs")
Signed-off-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions