diff options
| author | Bijan Mottahedeh <bijan.mottahedeh@oracle.com> | 2018-09-18 02:09:47 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2018-10-25 03:16:13 +0200 |
| commit | 0d02dbd68c47b66367130b696baef7246720791c (patch) | |
| tree | d0f5fe1edcc46df92d890e443e1b5d6d9b1be9a1 /certs/system_certificates.S | |
| parent | vhost/scsi: truncate T10 PI iov_iter to prot_bytes (diff) | |
| download | linux-0d02dbd68c47b66367130b696baef7246720791c.tar.xz linux-0d02dbd68c47b66367130b696baef7246720791c.zip | |
vhost/scsi: Respond to control queue operations
The vhost-scsi driver currently does not handle any control queue
operations. In particular, vhost_scsi_ctl_handle_kick, merely prints out
a debug message but does nothing else. This can cause guest VMs to hang.
As part of SCSI recovery from an error, e.g., an I/O timeout, the SCSI
midlayer attempts to abort the failed operation. The SCSI virtio driver
translates the abort to a SCSI TMF request that gets put on the control
queue (virtscsi_abort -> virtscsi_tmf). The SCSI virtio driver then
waits indefinitely for this request to be completed, but it never will
because vhost-scsi never responds to that request.
To avoid a hang, always respond to control queue operations; explicitly
reject TMF requests, and return a no-op response to event requests.
Signed-off-by: Bijan Mottahedeh <bijan.mottahedeh@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'certs/system_certificates.S')
0 files changed, 0 insertions, 0 deletions