diff options
| author | David S. Miller <davem@davemloft.net> | 2012-04-02 02:19:05 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-04-02 10:33:42 +0200 |
| commit | 6662df33f85b87bb29f2ecad124efe7bb2c08e05 (patch) | |
| tree | 13c8ac420b8d10ec3a7aa9aa7fdaa221e430c9cc /crypto/blkcipher.c | |
| parent | decnet: Stop using NLA_PUT*(). (diff) | |
| download | linux-6662df33f85b87bb29f2ecad124efe7bb2c08e05.tar.xz linux-6662df33f85b87bb29f2ecad124efe7bb2c08e05.zip | |
crypto: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/blkcipher.c')
| -rw-r--r-- | crypto/blkcipher.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/crypto/blkcipher.c b/crypto/blkcipher.c index 4dd80c725498..a8d85a1d670e 100644 --- a/crypto/blkcipher.c +++ b/crypto/blkcipher.c @@ -508,9 +508,9 @@ static int crypto_blkcipher_report(struct sk_buff *skb, struct crypto_alg *alg) rblkcipher.max_keysize = alg->cra_blkcipher.max_keysize; rblkcipher.ivsize = alg->cra_blkcipher.ivsize; - NLA_PUT(skb, CRYPTOCFGA_REPORT_BLKCIPHER, - sizeof(struct crypto_report_blkcipher), &rblkcipher); - + if (nla_put(skb, CRYPTOCFGA_REPORT_BLKCIPHER, + sizeof(struct crypto_report_blkcipher), &rblkcipher)) + goto nla_put_failure; return 0; nla_put_failure: |