diff options
author | Daniel Borkmann <daniel@iogearbox.net> | 2015-07-17 22:38:45 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-07-21 09:25:03 +0200 |
commit | 32b2f4b196b37695fdb42b31afcbc15399d6ef91 (patch) | |
tree | db51c8acd5f1049be5ceea4d9bc5f0b889e460ec /crypto/compress.c | |
parent | sched: cls_flower: fix panic on filter replace (diff) | |
download | linux-32b2f4b196b37695fdb42b31afcbc15399d6ef91.tar.xz linux-32b2f4b196b37695fdb42b31afcbc15399d6ef91.zip |
sched: cls_flow: fix panic on filter replace
The following test case causes a NULL pointer dereference in cls_flow:
tc filter add dev foo parent 1: handle 0x1 flow hash keys dst action ok
tc filter replace dev foo parent 1: pref 49152 handle 0x1 \
flow hash keys mark action drop
To be more precise, actually two different panics are fixed, the first
occurs because tcf_exts_init() is not called on the newly allocated
filter when we do a replace. And the second panic uncovered after that
happens since the arguments of list_replace_rcu() are swapped, the old
element needs to be the first argument and the new element the second.
Fixes: 70da9f0bf999 ("net: sched: cls_flow use RCU")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/compress.c')
0 files changed, 0 insertions, 0 deletions