diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2011-02-22 12:50:12 +0100 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2011-02-22 13:02:03 +0100 |
commit | 70433c01613c2a44756c7b25f7bdd6c1c77b119f (patch) | |
tree | 27fb95b4ccaa498a7bbae135835b8a0472147d1b /crypto/krng.c | |
parent | genirq: Add missing break in __irq_set_trigger() (diff) | |
download | linux-70433c01613c2a44756c7b25f7bdd6c1c77b119f.tar.xz linux-70433c01613c2a44756c7b25f7bdd6c1c77b119f.zip |
genirq: Use the correct variable for note_interrupt
note_interrupt wants to be called with the combined result of all
handlers called, not with the last one. If it's a shared interrupt
then the last handler might return IRQ_NONE often enough to trigger
the spurious dectector which turns off a perfectly fine working
interrupt line. Bug was introduced in commit 1277a532(genirq: Simplify
handle_irq_event()).
Yes, I really messed up there. First the variable ret should not have
been named differently to avoid similarity with retval. Second it
should have been declared in the do {} loop.
Rename it to res and move it into the do {} loop and vanish under a
huge brown paperbag.
Reported-bisected-tested-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'crypto/krng.c')
0 files changed, 0 insertions, 0 deletions