diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2019-12-20 06:29:40 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2019-12-27 11:18:04 +0100 |
| commit | b3c16bfc6a79ae517ec3c44be615aed0ffa52c53 (patch) | |
| tree | 1a0405808ed63f31289bee2ba5927cda3496e908 /crypto/pcbc.c | |
| parent | crypto: chtls - Fixed memory leak (diff) | |
| download | linux-b3c16bfc6a79ae517ec3c44be615aed0ffa52c53.tar.xz linux-b3c16bfc6a79ae517ec3c44be615aed0ffa52c53.zip | |
crypto: skcipher - Add skcipher_ialg_simple helper
This patch introduces the skcipher_ialg_simple helper which fetches
the crypto_alg structure from a simple skcipher instance's spawn.
This allows us to remove the third argument from the function
skcipher_alloc_instance_simple.
In doing so the reference count to the algorithm is now maintained
by the Crypto API and the caller no longer needs to drop the alg
refcount.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/pcbc.c')
| -rw-r--r-- | crypto/pcbc.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/crypto/pcbc.c b/crypto/pcbc.c index 862cdb8d8b6c..ae921fb74dc9 100644 --- a/crypto/pcbc.c +++ b/crypto/pcbc.c @@ -153,10 +153,9 @@ static int crypto_pcbc_decrypt(struct skcipher_request *req) static int crypto_pcbc_create(struct crypto_template *tmpl, struct rtattr **tb) { struct skcipher_instance *inst; - struct crypto_alg *alg; int err; - inst = skcipher_alloc_instance_simple(tmpl, tb, &alg); + inst = skcipher_alloc_instance_simple(tmpl, tb); if (IS_ERR(inst)) return PTR_ERR(inst); @@ -166,7 +165,7 @@ static int crypto_pcbc_create(struct crypto_template *tmpl, struct rtattr **tb) err = skcipher_register_instance(tmpl, inst); if (err) inst->free(inst); - crypto_mod_put(alg); + return err; } |