summaryrefslogtreecommitdiffstats
path: root/crypto/sig.c
diff options
context:
space:
mode:
authorjustinstitt@google.com <justinstitt@google.com>2023-07-19 00:56:38 +0200
committerDavid S. Miller <davem@davemloft.net>2023-07-23 12:45:46 +0200
commit5c9f7b04aadf79f783542d096dfbb8184e7c91f5 (patch)
treef647a4d21ae76b1f97c73d53086b72bd57694ed8 /crypto/sig.c
parentMerge branch 'process-connector-bug-fixes-and-enhancements' (diff)
downloadlinux-5c9f7b04aadf79f783542d096dfbb8184e7c91f5.tar.xz
linux-5c9f7b04aadf79f783542d096dfbb8184e7c91f5.zip
net: dsa: remove deprecated strncpy
`strncpy` is deprecated for use on NUL-terminated destination strings [1]. Even call sites utilizing length-bounded destination buffers should switch over to using `strtomem` or `strtomem_pad`. In this case, however, the compiler is unable to determine the size of the `data` buffer which renders `strtomem` unusable. Due to this, `strscpy` should be used. It should be noted that most call sites already zero-initialize the destination buffer. However, I've opted to use `strscpy_pad` to maintain the same exact behavior that `strncpy` produced (zero-padded tail up to `len`). Also see [3]. [1]: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [2]: elixir.bootlin.com/linux/v6.3/source/net/ethtool/ioctl.c#L1944 [3]: manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html Link: https://github.com/KSPP/linux/issues/90 Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Justin Stitt <justinstitt@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/sig.c')
0 files changed, 0 insertions, 0 deletions